Conversation
genedan
requested review from
henrydingliu,
jbogaardt and
kennethshsu
as code owners
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1033 +/- ##
==========================================
+ Coverage 89.17% 89.21% +0.03%
==========================================
Files 89 89
Lines 5165 5164 -1
Branches 661 661
==========================================
+ Hits 4606 4607 +1
+ Misses 392 390 -2
Partials 167 167
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
henrydingliu
approved these changes
Jun 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Adds a test for the 2 remaining lines in
io.py. Dumps a pickle, reads it back in, and compares.Related GitHub Issue(s)
Additional Context for Reviewers
uv run pytest) and documentation changes (uv run jb build docs --builder=custom --custom-builder=doctest)Note
Low Risk
Test-only coverage plus minor non-functional io.py housekeeping; no production logic changes.
Overview
Adds
test_triangle_to_pickle, which writes pickles viaTriangle.to_pickle(not rawdill.dump) for single-indexraaand multi-indexclrd, then assertscl.read_picklereturns an equal triangle and that the file exists—closing coverage gaps onTriangleIO.to_pickleinio.py.chainladder/core/io.pygets a short module docstring and import cleanup:joblibis removed, anddill/json/pandasare grouped at the top (behavior of pickle I/O unchanged).Reviewed by Cursor Bugbot for commit 433f940. Bugbot is set up for automated code reviews on this repo. Configure here.